mapbox / mapbox-navigation-ios

Turn-by-turn navigation logic and UI in Swift on iOS
https://docs.mapbox.com/ios/navigation/
Other
863 stars 313 forks source link

Steps table blank space fix #4708

Closed Udumft closed 3 months ago

Udumft commented 3 months ago

Description

Fixes blank space appearing in steps list table when next banner view should be shown. Also fixes rare issue with route simulation when puck could become stuck.

Implementation

Blank space is fixed by resolving logic of next banner view which was controlled by itself and the TopBannerViewController, which resulted in conflicting visibility config. Route simulation could sometimes become stuck in one place when expected segment travel time was not set, which resulted in simulated speed value to be calculated as NaN, which kept the puck in place.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.06%. Comparing base (c9255f7) to head (a053ab8). Report is 1 commits behind head on lts/v2.

Impacted file tree graph

@@            Coverage Diff             @@
##           lts/v2    #4708      +/-   ##
==========================================
- Coverage   60.07%   60.06%   -0.01%     
==========================================
  Files         189      189              
  Lines       21316    21316              
==========================================
- Hits        12806    12804       -2     
- Misses       8510     8512       +2     
Files Coverage Δ
...ces/MapboxNavigation/TopBannerViewController.swift 25.64% <100.00%> (ø)

... and 1 file with indirect coverage changes