[WIP] Traffic plugin - Githubissues

mapbox / mapbox-plugins-ios

Experimental plugins to supercharge your maps ⚡️

ISC License

7 stars 8 forks source link

[WIP] Traffic plugin #9

Closed jmkiley closed 7 years ago

jmkiley commented 7 years ago

To Do:

[x] Add method to add traffic layer above another layer.
[x] Cleanup code. ~- [ ] Carthage.~
[x] Read me/instructions for how to use.
[x] Have others test out installation.

friedbunny commented 7 years ago

Initial notes as I tried out the demo app in the repo:

Need to carthage bootstrap.
Need to create mapbox_access_token.
mapbox-plugins-ios/Funhouse/Info.plist': The file “Info.plist” couldn’t be opened because there is no such file.
There is no scheme with the same name as the Funhouse target — it appears to be called MapboxPlugins.
The test app effectively has three names — TestApp, Funhouse, and MapboxPlugins.
If the traffic layer isn’t available until ~z10, we should make a note of that (otherwise folks will load the thing and think it’s not working).

jmkiley commented 7 years ago

TY! I missed a few things when I was renaming from Funhouse -> TestApp. Working on catching everything now.

jmkiley commented 7 years ago

@friedbunny found an issue where the Mapbox framework isn't visible when you install through CocoaPods. I am working on fixing that now.

jmkiley commented 7 years ago

I think I resolved the Module not found issue in 5302a40. I changed @import Mapbox; to #import <Mapbox-iOS-SDK/Mapbox/Mapbox.h>. 🤞

jmkiley commented 7 years ago

Currently running into issues with using the Traffic Plugin in the TestApp, but it seems to be working via CocoaPods. Going to work on Carthage integration, then on fixing TestApp.

jmkiley commented 7 years ago

Capturing current status here. I am running into issues with:

[x] Running test apps on an actual device (Getting some Image not found and Lipo: input file must be a fat file crashes, depending on what I'm doing).
[ ] Test out Carthage.

Will work on both later today.

jmkiley commented 7 years ago

I am going to track the status of Carthage support here: https://github.com/mapbox/mapbox-plugins-ios/issues/10

Otherwise, I think think is ready for review.

CC @boundsj @friedbunny @1ec5

jmkiley commented 7 years ago

I think I've addressed most, if not all, of @friedbunny and @1ec5's feedback!

jmkiley commented 7 years ago

I think this is ready for re-review 😬

friedbunny commented 7 years ago

If you re-record trafficplugin.gif using v3.7.0 or master, the map styles will smoothly transition (instead of flashing and completely redrawing).

jmkiley commented 7 years ago

Addressed the feedback @1ec5! Thank you so much.

jmkiley commented 7 years ago

I think I addressed the latest suggestions, @1ec5. Thank you so much for your suggestions 🙇‍♀️