search

mapbox / mapbox-scenekit

Other
231 stars 51 forks source link

Combine separate latitude, longitude arguments into CLLocationCoordinate2D #12

Open 1ec5 opened 6 years ago

1ec5 commented 6 years ago

This library separates latitude and longitude into separate arguments or properties in many places. There is a strong convention on Apple platforms of using CLLocationCoordinate2D or CLLocation whenever possible to represent geographic coordinate pairs.

Some of the antipatterns below would be addressed by #7:

https://github.com/mapbox/mapbox-scenekit/blob/1969fee0de7bc314098550c67bcd32d086ec289b/MapboxSceneKit/MapboxImageAPI.swift#L100 https://github.com/mapbox/mapbox-scenekit/blob/1969fee0de7bc314098550c67bcd32d086ec289b/MapboxSceneKit/Tile%20Fetching/MapboxHTTPAPI.swift#L47 https://github.com/mapbox/mapbox-scenekit/blob/1969fee0de7bc314098550c67bcd32d086ec289b/MapboxSceneKit/TerrainNode.swift#L16-L24