search

mapbox / mapbox-scenekit

Other
231 stars 51 forks source link

Avoid extra copy of MapboxMobileEvents in app bundle #17

Closed 1ec5 closed 6 years ago

1ec5 commented 6 years ago

Fixed the following build issues in Xcode 10 caused by a redundant entry in the example application’s Copy Frameworks build phase:

error: Multiple commands produce '~/Library/Developer/Xcode/DerivedData/MapboxSceneKit-hefwdryezquuwtfqobkovumeulir/Build/Products/Debug-iphonesimulator/Examples.app/Frameworks/MapboxMobileEvents.framework':
1) Target 'Examples' has copy command from '~/hub/mapbox-scenekit/Carthage/Build/iOS/MapboxMobileEvents.framework' to '~/Library/Developer/Xcode/DerivedData/MapboxSceneKit-hefwdryezquuwtfqobkovumeulir/Build/Products/Debug-iphonesimulator/Examples.app/Frameworks/MapboxMobileEvents.framework'
2) That command depends on command in Target 'Examples': script phase “Copy Carthage Dependencies”
warning: ignoring duplicated output file: '~/Library/Developer/Xcode/DerivedData/MapboxSceneKit-hefwdryezquuwtfqobkovumeulir/Build/Products/Debug-iphonesimulator/Examples.app/Frameworks/MapboxMobileEvents.framework' (in target 'Examples')

This change removes that manual framework copy in favor of what Carthage’s build script does for both MapboxMobileEvents and the map SDK.

/cc @morgane