mapbox / mapbox-scenekit

Other
231 stars 51 forks source link

Newest master branch cannot be installed via Carthage #32

Closed natalia-osa closed 5 years ago

natalia-osa commented 6 years ago

Output from console:

*** Building scheme "MapboxMobileMetrics" in MapboxMobileEvents.xcodeproj
*** Building scheme "MapboxSceneKit" in MapboxSceneKit.xcodeproj
Build Failed
    Task failed with exit code 65:
    /usr/bin/xcrun xcodebuild -project /Users/osa/Developer/os-maps-ios/Carthage/Checkouts/mapbox-scenekit/MapboxSceneKit.xcodeproj -scheme MapboxSceneKit -configuration Release -derivedDataPath /Users/osa/Library/Caches/org.carthage.CarthageKit/DerivedData/mapbox-scenekit/ab51c31b911f24e79b04fb1585202d192525b554 -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build (launched in /Users/osa/Developer/os-maps-ios/Carthage/Checkouts/mapbox-scenekit)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/1s/n4cx8cln5rl3m2lqshy75gjr0000gn/T/carthage-xcodebuild.QAgrHQ.log

When compiling there are 7 errors.

avi-c commented 6 years ago

Looks like the latest change to use shader programs introduced a dependency on iOS 9. We'll look at how to either fall back on iOS 8.

natalia-osa commented 6 years ago

Yes, I've described the problem in details here: https://github.com/mapbox/mapbox-scenekit/pull/24#issuecomment-416510298. Fix for iOS 9 seems fairly easy, but iOS 8 may involve some more work.

natalia-osa commented 5 years ago

Fixed by undoing that merge.