search

mapbox / mapbox-scenekit

Other
231 stars 51 forks source link

Possibility to multiply height by given value #36

Closed natalia-osa closed 5 years ago

natalia-osa commented 6 years ago

This pull request enables to multiply the height by given constant. Handy when you're drawing a very flat terrain and want it to appear more realistic.

avi-c commented 6 years ago

Hi @natalia-osa

I'll look at the PR. You are right that something like this is needed in order to improve the visualization for flat terrain. I have used something similar myself but haven't prepared it as a PR, so thank you for your contribution.

natalia-osa commented 5 years ago

Should I update this PR to the newest codebase or you don't want to merge it and there's no need to put time into it..?

avi-c commented 5 years ago

I think it’s worth adding. Let’s update it and get it merged.

natalia-osa commented 5 years ago

@avi-c Changed.