search

mapbox / mapbox-sdk-cs

C# libraries for Mapbox API layer
https://mapbox.github.io/mapbox-sdk-cs/
Other
20 stars 11 forks source link

Make Tile.Cancel public #14

Closed david-rhodes closed 7 years ago

david-rhodes commented 7 years ago

Tile.Initialize is public, and therefore Tile.Cancel should be as well. I could see developers wanting to handle tile requests on their own, outside of Map.cs ( @brnkhy and I have already made our own map implementations for Unity).

As an aside, I could also see us backing this with an interface.

david-rhodes commented 7 years ago

@isiyu want to tackle this for beta? It's low risk and I could see developers wanting the ability to cancel requests.

isiyu commented 7 years ago

@david-rhodes i'll take a look; but the update process between mapbox-sdk-unity-core and mapbox-sdk-unity is still manual and cumbersome. I'd like to avoid making changes the day of the release.

MateoV commented 7 years ago

done in https://github.com/mapbox/mapbox-sdk-unity-core/commit/74ebf6fb57e5c7228f719970d61e84878ae36d26