search

mapbox / mapbox-sdk-cs

C# libraries for Mapbox API layer
https://mapbox.github.io/mapbox-sdk-cs/
Other
20 stars 11 forks source link

preparing 'mapbox-sdk-unity-core' to become 'mapbox-sdk-cs' #48

Closed wilhelmberg closed 7 years ago

wilhelmberg commented 7 years ago

1st for rebooting repos https://github.com/mapbox/games/issues/97

david-rhodes commented 7 years ago

LGTM. Why are checks failing?

wilhelmberg commented 7 years ago

LGTM. Why are checks failing?

hm, they weren't before. I'll check. Suppose #43 (color conversion) should have been merged before this PR not after.

wilhelmberg commented 7 years ago

Removed more references to Unity.

Already published a nupkg (although internal structure will most likely change during repos reboot): https://www.nuget.org/packages/MapboxSdkCs/

@isiyu what was your Microsoft ID again - so I can add to as owner on nuget.org?

AppVeyor is ✅: https://ci.appveyor.com/project/Mapbox/mapbox-sdk-unity-core/build/1.0.186

We should make sure everything Unity related is already carried over to mapbox-sdk-unity before merging. Eg functions removed from Util/Conversions.cs Who's taking care of that?

Todo after repo renaming: https://github.com/mapbox/mapbox-sdk-unity-core/issues/49

MateoV commented 7 years ago

This is on me now. Porting the conversions to the main sdk today, then plan to rename the script here and clean up any straggling references and unused vars.

isiyu commented 7 years ago

@BergWerkGIS - my windows login is iseeyou7787@hotmail.com

wilhelmberg commented 7 years ago

AppVeyor ✅ https://ci.appveyor.com/project/Mapbox/mapbox-sdk-unity-core/build/1.0.197/tests

From my point of view we are ready to merge and rename the repo.