wilhelmberg
commented
7 years ago YES!
@isiyu @david-rhodes please 👀
(build of this PR against master is failing on AppVeyor because appveyor.yml@master doesn't yet have env vars NUGET_API_KEY and GITHUB_TOKEN).
✅ versions are fetched from versions.txt and DLLs and nupkg are built/published with them
✅ [publish nuget]: https://ci.appveyor.com/project/Mapbox/mapbox-sdk-unity-core/build/1.0.40
✅ [publish docs]: https://ci.appveyor.com/project/Mapbox/mapbox-sdk-unity-core/build/1.0.48
Currently docs get pushed to gh-pages of this repo https://mapbox.github.io/mapbox-sdk-unity-core/
We should make a final decision where they should live???
- https://github.com/mapbox/mapbox-sdk-unity-core/tree/gh-pages
- https://github.com/mapbox/mapbox-sdk-unity-docs
- https://github.com/mapbox/mapbox-sdk-unity/tree/gh-pages
Next steps:
I think mainly #4 (publishing/installing nuget package questions):
- overhauling
nuspecto get thenupkginto the finalsdkeasier - publishing of final
sdkto S3
This PR unlocks 2 things:
Versioning
versions.txtin the root of the repo contains two lines:dlls: AppVeyor patches the version information of the DLLs to that version. It's good practice to keep DLL versions andnupkgversions in synch.nupkg: version of the nuget package. More flexible than thedllsversion as this can contain additional characters/numbers after the initial version (eg-alpha02)->this defines a pre-release version on nuget.org.Publishing
nuget.org
Include
[publish nuget]and AppVeyor pushes thenupkgwith the version information found inversions.txtto nuget.org. Beware! nuget.org doesn't allow overwriting of existing versions! Thenupkgversion inversions.txthas to be higher than the latest here: https://www.nuget.org/packages/MapboxSDKforUnityCore/docs
Include
[publish docs]and AppVeyor pushes the docs to mapbox-sdk-unity/gh-pages (notsdk-core) available at https://mapbox.github.io/mapbox-sdk-unity/