search

mapbox / mapbox-sdk-js

A JavaScript client to Mapbox services, supporting Node, browsers, and React Native
Other
706 stars 185 forks source link

Arbitrary geocoding arguments #311

Open scottsfarley93 opened 5 years ago

scottsfarley93 commented 5 years ago

Currently the arguments passed to the geocoding service are relatively controlled and limited. While this prevents unexpected behavior from adding invalid/unknown arguments to the geocoding api, it also introduces a barrier to adopting new api features (such as routable points]. Do we want to keep arguments to the service tightly scoped or could we modify https://github.com/mapbox/mapbox-sdk-js/blob/master/services/geocoding.js to accept arbitrary new arguments?

\cc @danswick @katydecorah @yuletide

danswick commented 5 years ago

Hi, @scottsfarley93. Interesting idea to allow arbitrary arguments! Any reason you wouldn't want to add those new features to the SDK directly? Is there some concern about stability that would be overcome by allowing arbitrary arguments?