search

mapbox / mapbox-sdk-js

A JavaScript client to Mapbox services, supporting Node, browsers, and React Native
Other
709 stars 185 forks source link

updated package got to 11.8.2 as previous version require electron at… #415

Closed tombombadilom closed 10 months ago

tombombadilom commented 3 years ago

… build and new version has electron removed

node -v v12.20.1 "gatsby": "^3.0.1", "react": "^17.0.1", "react-map-gl": "^6.1.11", "react-map-gl-geocoder": "^2.1.6",

here is what happend when you build @mapbox/mapbox-sdk with the old got version

ERROR #98124  WEBPACK
Generating SSR bundle failed
Can't resolve 'electron' in '{...}/node_modules/got'
If you're trying to use a package make sure that 'electron' is installed. If you're trying to use a local file make sure that the path is correct.
File: node_modules/got/index.js:91:20
not finished Building HTML renderer - 17.304s
allanlewis commented 2 years ago

I think is now redundant following the merge of #440.