search

mapbox / mapbox-sdk-rb

A Ruby interface to Mapbox APIs.
Other
59 stars 32 forks source link

Adds isochrone api #29

Closed samfader closed 5 years ago

samfader commented 5 years ago

https://www.mapbox.com/api-documentation/#isochrone

samfader commented 5 years ago

@Bathlamos it won't let me add you as a reviewer, but would you be up for looking at this? I know the tests need to be more robust, but I figured that could be a step 2.

Bathlamos commented 5 years ago

Alright, I'll take a look by Wednesday!

Bathlamos commented 5 years ago

@samfader I added a few comments, but it's nothing that would prevent the method from running correctly. It looks good to me!

samfader commented 5 years ago

Thanks @Bathlamos - how's it look now?

Bathlamos commented 5 years ago

@samfader Looks good to me. I answered your comment about unused variables.