Closed samfader closed 5 years ago
Hey @Bathlamos! Do you think you'd be up for a review at some point on this? No rush, of course, I know there's quite a bit. And if not, let me know.
@samfader other than a few minor points in the review, it looks good to me!
I don't know what's your roadmap for this, but I thought I'd chime in. There's some logic that can be centralized (esp. when it comes to building the urls). Also, validating parameters and triggering errors before generating the GET request could make this library more robust 😄
@Bathlamos Good input, thanks! My main goal at this point has been to get as many of the APIs as possible into the SDK, but it is definitely time to start thinking about those kind of improvements. Would you be willing to open a couple of issues in the repo with your thoughts on those? If not, I can certainly do it, but wanted to ask.
Also - not seeing any review here. Did you submit it?
Published 2.3.0 with these changes https://rubygems.org/gems/mapbox-sdk/versions/2.3.0
cc @HeyStenson (FYI for docs)