Adds matrix, map matching, optimization api endpoints

mapbox / mapbox-sdk-rb

A Ruby interface to Mapbox APIs.

Other

59 stars 32 forks source link

Adds matrix, map matching, optimization api endpoints #39

Closed samfader closed 5 years ago

samfader commented 5 years ago

[x] Add Matrix API endpoint
[x] Add Matrix tests
[x] Add Matrix docs
[x] Add Map Matching API endpoint
[x] Add Map Matching tests
[x] Add Map Matching docs
[x] Add Optimization API endpoint
[x] Add Optimization tests
[x] Add Optimization docs
[x] Update changelog
[x] Push new version to rubygems once merged

cc @HeyStenson (FYI for docs)

samfader commented 5 years ago

Hey @Bathlamos! Do you think you'd be up for a review at some point on this? No rush, of course, I know there's quite a bit. And if not, let me know.

Bathlamos commented 5 years ago

@samfader other than a few minor points in the review, it looks good to me!

I don't know what's your roadmap for this, but I thought I'd chime in. There's some logic that can be centralized (esp. when it comes to building the urls). Also, validating parameters and triggering errors before generating the GET request could make this library more robust 😄

samfader commented 5 years ago

@Bathlamos Good input, thanks! My main goal at this point has been to get as many of the APIs as possible into the SDK, but it is definitely time to start thinking about those kind of improvements. Would you be willing to open a couple of issues in the repo with your thoughts on those? If not, I can certainly do it, but wanted to ask.

Also - not seeing any review here. Did you submit it?

samfader commented 5 years ago

Published 2.3.0 with these changes https://rubygems.org/gems/mapbox-sdk/versions/2.3.0