search

mapbox / mapbox-sdk-rb

A Ruby interface to Mapbox APIs.
Other
59 stars 32 forks source link

Add accounts tokens endpoints (work by @morgant) #44

Open samfader opened 5 years ago

samfader commented 5 years ago

@morgant Per https://github.com/mapbox/mapbox-sdk-rb/pull/43#issuecomment-520473137, putting your PR in here with a local branch to ensure tests pass.

samfader commented 5 years ago

@morgant Thoughts on these failing tests? I don't think they are related to a missing token; that appears to be correctly being pulled as an environment variable.

I haven't looked deeply due to time constraints. Let me know if you think it's something on the admin side.

morgant commented 5 years ago

@samfader Thanks for your continued work on this! Looking at the Travis CI job log, I don't see the new MapboxUsername environment variable being set, only the MapboxAccessToken. Please correct me if I'm wrong. Is that something you have access to set? If so, it should be the Mapbox username associated with the account the access token was created under.

samfader commented 4 years ago

Hey @morgant, thanks for your patience. I've been meaning to come back to this for a while. I've decided that the best approach will be to mock these tests - I don't feel great about creating and deleting tokens on a real account. I'm looking into this approach now.

woodhull commented 2 years ago

Just re-upping this as a feature request, it's been "almost mergeable" as a feature across two different PRs for a few years now.