search

mapbox / mapbox-sdk-rb

A Ruby interface to Mapbox APIs.
Other
59 stars 32 forks source link

Replace URI.escape with encode_www_form_component #48

Closed talsafran closed 3 years ago

talsafran commented 3 years ago

Should resolve https://github.com/mapbox/mapbox-sdk-rb/issues/47

talsafran commented 3 years ago

@andrii-rymar @samfader hi 👋! Do you have any feedback on this PR or on @redcode's #46? We'd love to get rid of these noisy lil warnings. Thanks!

❤️:octocat: your friends at GitHub

redcode commented 3 years ago

@andrii-rymar @samfader hi wave! Do you have any feedback on this PR or on @redcode's #46? We'd love to get rid of these noisy lil warnings. Thanks!

heart:octocat: your friends at GitHub

I think you mean @redscode. I have nothing to do here.

samfader commented 3 years ago

Thanks @talsafran - will release it along with https://github.com/mapbox/mapbox-sdk-rb/pull/46

samfader commented 3 years ago

https://rubygems.org/gems/mapbox-sdk - released in 2.3.2

talsafran commented 3 years ago

Thanks @samfader ❤️