search

mapbox / mapbox-sdk-rb

A Ruby interface to Mapbox APIs.
Other
59 stars 32 forks source link

Update rest-client to 2.1.0 #51

Closed andrii-rymar closed 3 years ago

andrii-rymar commented 3 years ago

Related to #50

Updating rest-client to it's latest version to avoid dependency conflicts with a lot of other libs locked with 2.1.0.

andrii-rymar commented 3 years ago

@samfader I'm seeing Travis tests failing due to missing API token. Guess we can add an encrypted token into .travis.yml but it will be accessible only from the main repo, not from the forks. Have no ideas how can we resolve it...

Anyway tests are good locally.

samfader commented 3 years ago

Looks good @andrii-rymar. Are you open to pushing the gem update to rubygems (https://guides.rubygems.org/publishing/)? I can give you push permissions if that's something you'd be open to.

andrii-rymar commented 3 years ago

@samfader sure, let's do it. Guess we need another PR to bump whole gem to 2.3.1, right?

samfader commented 3 years ago

@andrii-rymar Yes, would need that as well if you don't mind. Can you share your email I should use to send Rubygems permissions? Let me know if you'd prefer to share off of a public thread.

andrii-rymar commented 3 years ago

@samfader here is an email you can send it: onegloriouspenguin@gmail.com. Thanks

samfader commented 3 years ago

@andrii-rymar Do you have a rubygems.org account with that email? Says it couldn't find this user...

andrii-rymar commented 3 years ago

@samfader it should be in place now.

samfader commented 3 years ago

@andrii-rymar done, thanks. Will approve other PR now.

andrii-rymar commented 3 years ago

@samfader thanks