Closed andrii-rymar closed 3 years ago
@samfader I'm seeing Travis tests failing due to missing API token. Guess we can add an encrypted token into .travis.yml but it will be accessible only from the main repo, not from the forks. Have no ideas how can we resolve it...
Anyway tests are good locally.
Looks good @andrii-rymar. Are you open to pushing the gem update to rubygems (https://guides.rubygems.org/publishing/)? I can give you push permissions if that's something you'd be open to.
@samfader sure, let's do it. Guess we need another PR to bump whole gem to 2.3.1, right?
@andrii-rymar Yes, would need that as well if you don't mind. Can you share your email I should use to send Rubygems permissions? Let me know if you'd prefer to share off of a public thread.
@samfader here is an email you can send it: onegloriouspenguin@gmail.com. Thanks
@andrii-rymar Do you have a rubygems.org account with that email? Says it couldn't find this user...
@samfader it should be in place now.
@andrii-rymar done, thanks. Will approve other PR now.
@samfader thanks
Related to #50
Updating rest-client to it's latest version to avoid dependency conflicts with a lot of other libs locked with 2.1.0.