search

mapbox / mapbox-search-ios

Search SDK for iOS with preconfigured UI in Swift
https://docs.mapbox.com/ios/search/guides/
Other
15 stars 19 forks source link

Xcode Cloud support for version 2.0.0+ #187

Closed AlfredReisner closed 1 week ago

AlfredReisner commented 2 months ago

Hello Mapbox Search team,

we are using Xcode Cloud as internal CI pipeline to build the mapbox-search-ios framework 2.0.0-rc.2 setup with SPM. When building with Xcode 15.3+ we are receiving the follow configuration error:

Invalid Bundle. The bundle *.app/Frameworks/MapboxCoreSearch.framework does not support the minimum OS Version specified in the Info.plist.

The bundle 'Payload/*.app/Frameworks/MapboxCoreSearch.framework' is missing plist key. The Info.plist file is missing the required key: CFBundleShortVersionString. Please find more information about CFBundleShortVersionString at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring

This bundle Payload/*.app/Frameworks/MapboxCoreSearch.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion. Please find more information about CFBundleVersion at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion

Could u please have a look to fix the configuration for us? If u need any additional information, please reach out to us.

Thanks.

aokj4ck commented 2 months ago

Hi @AlfredReisner I'm setting up my own Xcode Cloud environment on a development branch to help triage this issue. Was Xcode Cloud previously working correctly with earlier versions of Xcode or Mapbox SDKs? Can you share your minimum OS version for your project?

AlfredReisner commented 2 months ago

Hi, v2.0.0+ still works when we build the pipeline on Xcode 15.2. Only Xcode 15.3+ drops this configuration error. Our minimum OS version is iOS 16.0. We are also using Mapbox-Maps 11.1.0 and Mapbox-Directions 2.11.1. No issues occur on these SDKs.

aokj4ck commented 2 months ago

@AlfredReisner I have a draft pull request available which will update MapboxCoreSearch.framework at https://github.com/mapbox/mapbox-search-ios/pull/196. This version of MapboxCoreSearch is built using Xcode 15.3.

If you wouldn't mind, please try building your app with the MapboxSearch package fetching from branch SSDK-643-upgrade-search-core-alpha.14 [link to branch].

Screenshot 2024-03-21 at 11 03 44
AlfredReisner commented 2 months ago

@aokj4ck Unfortunately the pipeline drops the same configuration error using the mentioned branch. Maybe to clarify a bit more again. We can build the framework using Xcode 15.3 locally. It is just Xcode Cloud which drops the error and prevents us to build the project. As a workaround for now we stay on Xcode 15.2 with 2.0.0-rc.2 set as dependency but it would be great to get this fixed in future releases.

aokj4ck commented 1 month ago

@AlfredReisner and to confirm are you using SPM for your mapbox-search-ios dependency, or another system?

AlfredReisner commented 1 month ago

@aokj4ck Yes, that is correct.

aokj4ck commented 2 weeks ago

@AlfredReisner please update to our latest release v2.0.3 and let me know if you encounter any issues. https://github.com/mapbox/mapbox-search-ios/releases/tag/v2.0.3

AlfredReisner commented 2 weeks ago

@aokj4ck v2.0.3 solves the issue. Thanks a lot!