mapbox / mapbox-speech-swift

Natural-sounding text-to-speech in Swift or Objective-C on iOS, macOS, tvOS, and watchOS
ISC License
43 stars 17 forks source link

Incorrect Info.plist entries #7

Closed 1ec5 closed 6 years ago

1ec5 commented 6 years ago

The marketing version number in the Info.plist is set to 1.0 instead of 0.1. This affects a constant that’s exposed publicly:

https://github.com/mapbox/mapbox-speech-swift/blob/14787d40c10f023f577234a41395284404c6bb45/MapboxSpeech/Info.plist#L17-L18

Additionally, the bundle identifier is incorrectly set to com.Mapbox.MapboxSpeech instead of com.mapbox.MapboxSpeech:

https://github.com/mapbox/mapbox-speech-swift/blob/14787d40c10f023f577234a41395284404c6bb45/MapboxSpeech.xcodeproj/project.pbxproj#L383

/cc @bsudekum