search

mapbox / mapbox-studio-classic

https://www.mapbox.com/mapbox-studio/
BSD 3-Clause "New" or "Revised" License
1.14k stars 229 forks source link

Support TopoJSON files with .topojson extension #1149

Open springmeyer opened 9 years ago

springmeyer commented 9 years ago

The file filtering regex in the filebrowser is too strict which makes it seem like .topojson is not supported.

ohsk commented 9 years ago

@springmeyer was just trying to use some .topojson files that have been generated using Mike Bostock's Topojson converter. Mapbox Studio seemed to recognize smaller topojson files just fine (without attributes, though), but wasn't able to load / make visible datasets over 40MB. Is that part of this bug, or should Mabox Studio currently be able to support larger .topojson files?

springmeyer commented 9 years ago

@ohsk thanks for the details. This bug is purely about the lack of support for the .topojson extension name. So, TopoJSON files with a .json extension should work fine already.

Mapbox Studio seemed to recognize smaller topojson files just fine (without attributes, though), but wasn't able to load / make visible datasets over 40MB

Can you create two new issues for those problems? For the lacking attributes, please post a small file testcase. And for the large problem, can you share the commands/example of how you created?

We should be able to fix both issues in the coming weeks.

ohsk commented 9 years ago

Gotcha, can do!