Test failure with latest mb-pages branch

mapbox / mapbox-studio-classic

https://www.mapbox.com/mapbox-studio/

BSD 3-Clause "New" or "Revised" License

1.14k stars 229 forks source link

Test failure with latest mb-pages branch #1335

Closed springmeyer closed 9 years ago

springmeyer commented 9 years ago

# data test: geojson/places.geo.json
ok 133 shows #addlayer modal
ok 134 should be equal
not ok 135 no error
  ---
    operator: ok
    expected: true
    actual:   false
  ...

This looks very similiar to what I though I fixed with the help of @GretaCB in https://github.com/mapbox/mapbox-studio/commit/c0730db6223f4edbfb23d891f680e8632297474a. It was a fix followup to https://github.com/mapbox/mapbox-studio/commit/1ccf37cb1701c753a711c0484aa65c34476df08d

springmeyer commented 9 years ago

Okay, confirmed that this is because node-mapnik 3.2.0 does not yet have this fix from upstream mapnik: https://github.com/mapnik/mapnik/issues/2745. So, this test will be failing until we upgrade to node-mapnik 3.3.0: https://github.com/mapnik/node-mapnik/milestones/v3.3.0