search

mapbox / mapbox-studio-classic

https://www.mapbox.com/mapbox-studio/
BSD 3-Clause "New" or "Revised" License
1.14k stars 229 forks source link

Failing test only on linux with node v0.10.30 #1433

Closed springmeyer closed 9 years ago

springmeyer commented 9 years ago

We currently have 3 jobs passing in the vs2015 branch (upcoming release) and only one failing: https://travis-ci.org/mapbox/mapbox-studio

That failing job has one failing test:

not ok 248 saves thumb
  ---
    operator: ok
    expected: true
    actual:   false
    at: null._onTimeout (/home/travis/build/mapbox/mapbox-studio/test/source.test.js:346:15)
  ...

Both @BergWerkGIS and I wonder if this is the same node v0.10.x bug seen elsewhere (api-maps).

springmeyer commented 9 years ago

upgrading to node v0.10.40 solves this failing test: https://travis-ci.org/mapbox/mapbox-studio/builds/76305474

springmeyer commented 9 years ago

Thanks @jakepruitt! This issue is now resolved by df18660343676ceff8e and 856103c

jakepruitt commented 9 years ago

Awesome, thanks for doing the update in mapbox-studio!