search

mapbox / mapbox-studio-classic

https://www.mapbox.com/mapbox-studio/
BSD 3-Clause "New" or "Revised" License
1.14k stars 229 forks source link

Mapbox Studio --> Mapbox Studio Classic #1451

Closed lyzidiamond closed 9 years ago

lyzidiamond commented 9 years ago

On 9/15, this PR will be merged and we will rename the repo mapbox-studio-classic.

/cc @tmcw

springmeyer commented 9 years ago

Sounds good @lyzidiamond - travis is should start passing in your branch if you grab the latest from master (my fault).

bsudekum commented 9 years ago

@BergWerkGIS @yhahn I just updated the build process to account for the new name. This is minimally invasive and does not change the name of the app running on your machine. Want to take a look at https://github.com/mapbox/mapbox-studio/commit/9e15d1498c977f8562e07a7871c9df2ae98ce3c7 ?

Update: https://github.com/mapbox/mapbox-studio/pull/1451#issuecomment-140236607

scothis commented 9 years ago

is it ok that CI is failing?

lyzidiamond commented 9 years ago

@scothis per chat with @springmeyer last week:

I should have just fixed master https://travis-ci.org/mapbox/mapbox-studio/builds/79380379

merging in master should make travis happy!

scothis commented 9 years ago

@bsudekum can you take a look at this test failure https://travis-ci.org/mapbox/mapbox-studio/jobs/80293959#L1726

bsudekum commented 9 years ago

@lyzidiamond I merged master in already.

appveyor is failing because of https://github.com/mapbox/mapbox-studio/commit/9e15d1498c977f8562e07a7871c9df2ae98ce3c7#diff-180360612c6b8c4ed830919bbb4dd459R4 and won't pass until the repo has changed it's name.

Looking into travis errors now.

bsudekum commented 9 years ago

Per discussion with @scothis, we're going to rely on github.com url redirects for publish processes.

wilhelmberg commented 9 years ago

@bsudekum @lyzidiamond

AppVeyor could be made pass by overriding the clone directory via:

clone_folder: c:\projects\myproject

http://www.appveyor.com/docs/appveyor-yml

Also noting that v0.2.8-alpha is the current development branch. Could you create another classic-PR and see that it can be merged with v0.2.8-alpha?

wilhelmberg commented 9 years ago

@bsudekum @lyzidiamond change of plans. no new PR necessary on your side .

just chatted with @yhahn @springmeyer @flippmoke : We are going to merge v0.2.8-alpha into mb-pages first and then classic.