mapbox / mapbox-vision-android

Other
50 stars 43 forks source link

Branch protection on dev not adhering to best practices #281

Open mapbox-github-ci-issues-4[bot] opened 1 year ago

mapbox-github-ci-issues-4[bot] commented 1 year ago

:wave: Hey there! It's Changebot, and I help repositories follow our engineering best practices. My magic wand found some things I wanted to highlight for your review:

Item Current status Best practice guidelines
dev branch protection: Dismiss stale pull request approvals when new commits are pushed Unchecked Checked
dev branch protection: Require review from Code Owners Unchecked Checked
dev branch protection: Restrict who can dismiss pull request reviews Unchecked Checked
dev branch protection: Require status checks to pass before merging Unchecked Checked
dev branch protection: Restrict who can push to this branch Unchecked Checked

Can you take a look at these best practices and make any adjustments if needed?

Please tag @mapbox/security-and-compliance on this issue if you have any questions