mapbox / mapbox.js

Mapbox JavaScript API, a Leaflet Plugin
mapbox.com/mapbox.js/
Other
1.92k stars 386 forks source link

Transfer /mapbox.js to docs.mapbox.com #1276

Closed davidtheclark closed 5 years ago

davidtheclark commented 5 years ago

@mapbox/frontend-platform and @mapbox/docs are working together to transfer this site to the new docs.mapbox.com domain.

Here are the steps in the process.

We're going to start on this today, and try to finish it today or tomorrow.

davidtheclark commented 5 years ago

The staging site is now live at https://docs.tilestream.net/mapbox.js. I ran the link checker and didn't find any problems.

@mapbox/docs could you please check out the staging site before we proceed?

katydecorah commented 5 years ago

@davidtheclark

Everything looks like it's working well, but there are two things I wasn't sure about:

davidtheclark commented 5 years ago

Thanks, @katydecorah.

The first point is a CDN configuration problem. Since mapbox.js looks like it's requesting a file, a trailing slash is not added and /index.html is not appended. We'll have to make a special case for this URL path in the CDN. I'll work on this.

The maps in examples on the current staging site, https://122e4e-mapbox.global.ssl.fastly.net/mapbox.js/, also do not work — so I'm guessing this isn't a problem. When we deploy to production we can check this before we push the redirect live.

davidtheclark commented 5 years ago

Another possibility, to keep complexity out of the CDN configuration, would be to change this site's URL to mapbox-js. What do you think of those two options, @mapbox/docs ?

katydecorah commented 5 years ago

change this site's URL to mapbox-js

@davidtheclark good solution, I think we should go with that

davidtheclark commented 5 years ago

We chatted about keeping the mapbox.js URL path for now. That change is live, so https://docs.tilestream.net/mapbox.js should now work fine. Do you see any other problems?

katydecorah commented 5 years ago

@davidtheclark works great! I have not found any other problems related to this work

davidtheclark commented 5 years ago

The production site is live now at https://docs.mapbox.com/mapbox.js.

It looks to me like the example maps are working just fine.

Please let me know if you find any problems. Will implement the redirects later today.

davidtheclark commented 5 years ago

Transfer is complete!

I switched the repo's main branch to publisher-production, changed the base branch of all open PRs, and deleted dev-pages and mb-pages.