protocol detection fails with non-mapbox urls (atlas)

mapbox / mapbox.js

Mapbox JavaScript API, a Leaflet Plugin

mapbox.com/mapbox.js/

Other

1.92k stars 386 forks source link

protocol detection fails with non-mapbox urls (atlas) #1303

Closed whyvez closed 4 years ago

whyvez commented 4 years ago

We've run into a problem using mapbox.js with atlas. How the src/request module detects the protocol is a bit too strict and does not take into account alternate tile endpoints such as with Mapbox Atlas.

Is there a reason the regex is strict to mapbox url's? /^(https?:)?(?=\/\/(.|api)\.tiles\.mapbox\.com\/)
If not could the regex be simplified to /^(https?:)

whyvez commented 4 years ago

Issue not related to the src/request module but the src/format_url module. Specifically this line: https://github.com/mapbox/mapbox.js/blob/publisher-production/src/format_url.js#L57