search

mapbox / mapbox.js

Mapbox JavaScript API, a Leaflet Plugin
mapbox.com/mapbox.js/
Other
1.91k stars 386 forks source link

correct overzooming bug when maxZoom options are specified by user #1323

Closed riastrad closed 3 years ago

riastrad commented 4 years ago

Resolves #1250

Back in 2018, @tvblomberg put up a PR that solved an overzooming bug (ref. https://github.com/mapbox/mapbox.js/pull/1251).

The bug fix is sound, but enough time has passed that I think pulling these changes into a new PR and testing them against the current state of the repo. I also want to add a manual test that can be used to quickly determine if this has regressed.

riastrad commented 4 years ago

Checking with the manual test, the patch does not appear to resolve the erroneous behavior.

Kapture 2020-03-18 at 16 29 28

So this one actually requires more digging, and as a result I'm going to descope it from the v3.3.0 release.