search

mapbox / mapboxgl-jupyter

Use Mapbox GL JS to visualize data in a Python Jupyter notebook
MIT License
665 stars 138 forks source link

Default width in LineString Vis is coerced to a sting #108

Closed jamiecook closed 6 years ago

jamiecook commented 6 years ago

I believe that this line in the linestring vis has the same problem as reported in #72

https://github.com/mapbox/mapboxgl-jupyter/blob/master/mapboxgl/templates/linestring.html#L61

specifically image

ryanbaumann commented 6 years ago

Thanks for the bug! Yes, this is the same bug. Fix is to remove the double quotes in the linestring template around {{defaultWidth }}.

jamiecook commented 6 years ago

Thanks @ryanbaumann ... i wasn't sure if there were other aspects of #74 that were also applicable otherwise I would have just raised a PR... I'll do that now