mapbox / mapboxgl-jupyter

Use Mapbox GL JS to visualize data in a Python Jupyter notebook
MIT License
661 stars 136 forks source link

Add missing dependencies requests and ipython #172

Closed jagill closed 4 years ago

jagill commented 4 years ago

The file viz.py imports both requests and IPython, but these are not declared in setup.py. Because of this, after a pip install mapboxgl, attempting to import mapgoxgl.utils fails.

This adds the packages to setup.py, and after this the import succeeds.

chuckwondo commented 7 months ago

Any chance a new release can be created so that this fix is included (along with any others that have since landed on master since 0.10.2 was released)? The missing imports has bitten me, and I must remember to explicitly include ipython in my own dependency list.