search

mapbox / mapnik-omnivore

Node module that returns metadata about spatial files.
44 stars 19 forks source link

Update tests to work with mapnik >= v3.0.12 #146

Closed artemp closed 8 years ago

artemp commented 8 years ago

Starting from v3.0.12 Datasource always returns valid (not a NULL) Featureset object.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.095% when pulling 2c7c57ee2953ddbd229aa29f263bdd8f5f2a2f20 on mapnik-3.0.12 into 6d548950f069add811b74344da442220896361bc on master.

springmeyer commented 8 years ago

Landed in https://github.com/mapbox/mapnik-omnivore/commit/2fbd39a50c15b7e0c588b85137ac68932cae46e6. This change works with older and upcoming Mapnik versions. After reviewing the message I've concluded that this change is an improvement overall because no matter the Mapnik behavior, if we get to this stage in using a datasource the GeoJSON file must be a FeatureCollection is not generic enough as it is more likely an empty featureset.

springmeyer commented 8 years ago

Next action over at https://github.com/mapnik/node-mapnik/pull/688 (to ensure that a test like this would remain passing no matter the mapnik version).