CSV error message handling

mapbox / mapnik-omnivore

Node module that returns metadata about spatial files.

45 stars 19 forks source link

CSV error message handling #161

Closed who8mycakes closed 7 years ago

who8mycakes commented 7 years ago

In tandem with error message revisions made in Mapnik: https://github.com/mapnik/mapnik/commit/7c6f335fa5b2194a2d52a6b78d2c02f056c29289,

This PR's objectives are to:

[x] Truncating error messages to 256 characters.
[x] Make sure all datasource creation steps in mapnik-omnivore are wrapped in a try/catch statement.
[x] Adding valid and invalid test fixtures + tests that assert error/no error based on those fixtures

coveralls commented 7 years ago

Changes Unknown when pulling de39b21cf919da1a0334a06bef27d709b3b76105 on shortererror into on master.

coveralls commented 7 years ago

Changes Unknown when pulling d684f71a316f2721fbe8d613b76e57abebbcbf55 on shortererror into on master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 95.085% when pulling d55951b1c7db2c71cd1e8472807e9e977ecfb991 on shortererror into 7cf3c919a124675bd885c77fd701a3a9b6be1f5a on 8.3.0.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 95.085% when pulling 77f521394f794c8b3aa73d7bd24f9952f515b709 on shortererror into dadb45fd2d6776e93d2b24f7a04f14c5c086c8d1 on 8.3.0.