mapbox / mapnik-omnivore

Node module that returns metadata about spatial files.
45 stars 19 forks source link

Feature-specific zoom calculations #163

Closed mapsam closed 7 years ago

mapsam commented 7 years ago

This PR adds some extra logic that allows us to begin calculating better maximum zooms based on feature types rather than just file size and extent using the mapnik.datasource.describe() method, can tell us if we are working with point, line, polygon, or mixed datasets. Right now this only adds a newly calculated "smallest maximum zoom" for point datasets that are less than 1MB.

In the future, we should look into:

refs: https://github.com/mapbox/mapnik-omnivore/issues/140

cc @GretaCB @who8mycakes

GretaCB commented 7 years ago

Love iiiiiit 🙌 Only 👀 are 🔴 Travis tests.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 95.212% when pulling 532a0f0e3a76500c441786e93a559d7551cb2076 on we-need-to-go-deeper into a43406828db595486db2a7ebaebdf8d941a793a1 on 8.3.0.