mapbox / mapnik-vector-tile

Mapnik implemention of Mapbox Vector Tile specification
BSD 3-Clause "New" or "Revised" License
553 stars 117 forks source link

V2 spec #169

Closed springmeyer closed 8 years ago

springmeyer commented 8 years ago

Implementation of https://github.com/mapbox/vector-tile-spec/tree/master/2.0

springmeyer commented 8 years ago

@flippmoke we spoke earlier about this branch being blocked by compiles not yet working on travis due to outdated mapnik-latest mason packages. Well, they are now updated for OS X. Dude to llvm.org being offline today that prevented the linux packages from getting built. Once someone commits to mapnik master again and the linux builds work then mapnik-latest packages will be available for both platforms.

springmeyer commented 8 years ago

Okay, packages are updated. Now the travis test failures are something to do with comparison of geojson strings (https://travis-ci.org/mapbox/mapnik-vector-tile/jobs/100448532#L782). Back to @flippmoke to figure these out.

flippmoke commented 8 years ago

@springmeyer @artemp https://travis-ci.org/mapbox/mapnik-vector-tile/jobs/100645511 had a failure -- this is due to the memory leaking issues in mapnik. This will continue until randomly on some builds until https://github.com/mapnik/mapnik/pull/3219 is merged into master and mason is rebuilt.

springmeyer commented 8 years ago

@springmeyer @artemp https://travis-ci.org/mapbox/mapnik-vector-tile/jobs/100645511 had a failure -- this is due to the memory leaking issues in mapnik. This will continue until randomly on some builds until mapnik/mapnik#3219 is merged into master and mason is rebuilt.

Hmm, what evidence do we have that https://github.com/mapnik/mapnik/pull/3219 fixes. If it fixes then why?

flippmoke commented 8 years ago

@springmeyer memory errors notified by -fsanitize=address and changing the line removes the errors we are seeing. @artemp looked into this a couple days ago.