Too much copying / too little const

mapbox / mapnik-vector-tile

Mapnik implemention of Mapbox Vector Tile specification

BSD 3-Clause "New" or "Revised" License

553 stars 117 forks source link

Too much copying / too little const #175

Closed springmeyer closed 8 years ago

springmeyer commented 8 years ago

The v2_spec branch has a few things I'm going to start fixing and want to encourage others to notice and fix further. I'll tag this issue to track commits. The two main issues are:

excessive and unnecessary copying of objects (where copying is expensive)
usage of nonconst references (type &) where const should be used (type const&)

/cc @flippmoke @jakepruitt @artemp

springmeyer commented 8 years ago

first pass done here, closing.