mapbox / mapnik-vector-tile

Mapnik implemention of Mapbox Vector Tile specification
BSD 3-Clause "New" or "Revised" License
553 stars 117 forks source link

Overhead in std::launch::deferred #183

Closed springmeyer closed 8 years ago

springmeyer commented 8 years ago

Profiling ./build/Release/vtile-encode ./test/geometry-test-data/input/counter-clockwise-polygon.json 0 0 0 -i 100000000 with Activity Monitor shows significant (> 2 %) of time taken in std::future and std::async::deferred usage. This says to me that locks are being invoked even when we are running synchronously, which is bad and indicates we may want to re-write to not use futures when we are not using std::launch::async (assuming this also impacts linux):

screen shot 2016-01-26 at 4 01 02 pm

screen shot 2016-01-26 at 4 00 42 pm

flippmoke commented 8 years ago

This has been addressed already and deferred launch does not require calling to std async.