Closed flippmoke closed 8 years ago
@flippmoke - why are you not using mapnik::util::is_clockwise
? We must stamp down on duplicate code as it's only encourages 🐛 's .
@artemp it no longer does it in the same way as it is done in a streaming fashion as the geometry is decoded. Therefore, I can no longer use the same method.
./build/Release/vtile-decode ./test/data/0.0.0.vector.mvt 0 0 0 100000
z:0 x:0 y:0 iterations:100000
message: gzip compressed
8313.71ms (cpu 8282.74ms) | decode as datasource_pbf: ./test/data/0.0.0.vector.mvt
processed 800000 features
./build/Release/vtile-decode ./test/data/0.0.0.vector.mvt 0 0 0 100000
z:0 x:0 y:0 iterations:100000
message: gzip compressed
7916.56ms (cpu 7883.13ms) | decode as datasource_pbf: ./test/data/0.0.0.vector.mvt
processed 800000 features
@flippmoke - this looks great, I think it is ready to 🚢
Fixed the way the decoder dealt with discarding interior and exterior rings when using bounding boxes. Also moved processing of vector tile area into vector tile coordinates so that clockwise and counterclockwise are more properly calculated.
/cc @springmeyer @jakepruitt