mapbox / mapnik-vector-tile

Mapnik implemention of Mapbox Vector Tile specification
BSD 3-Clause "New" or "Revised" License
553 stars 117 forks source link

Visual comparisons instead of geojson text comparisons #205

Open springmeyer opened 8 years ago

springmeyer commented 8 years ago

We need to add support for visual comparisons of changes in geometry outputs. Minor changes in floating point differences currently trigger the need for massive updates to the test fixtures like https://github.com/mapnik/geometry-test-data/commit/65abcf0600d25aefebfe77c62261d4c1d7ac4d31 which is dangerous because:

A visual approach (rendered png) would make it viable to review all the changes efficiently rather than just hope for the best.

pnorman commented 8 years ago

pretty printing the json might also help, it would mean that when one value changes you can get a more meaningful diff.