search

mapbox / mapnik-vector-tile

Mapnik implemention of Mapbox Vector Tile specification
BSD 3-Clause "New" or "Revised" License
553 stars 117 forks source link

add test - filtering by scale denominator on layer level #242

Closed talaj closed 7 years ago

talaj commented 7 years ago

The test covers filtering layers by scale denominator and shows it works. In https://github.com/mapbox/mapnik-vector-tile/issues/230 is claimed otherwise.

codecov-io commented 7 years ago

Codecov Report

Merging #242 into master will decrease coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   60.17%   60.12%   -0.06%     
==========================================
  Files          30       30              
  Lines        2142     2144       +2     
==========================================
  Hits         1289     1289              
- Misses        853      855       +2
Impacted Files Coverage Δ
src/vector_tile_geometry_clipper.hpp 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15d499e...e4c13d2. Read the comment docs.

springmeyer commented 7 years ago

Thank you for the test additions @talaj - per https://github.com/mapbox/mapnik-vector-tile/pull/243#issuecomment-304705517 there is one unrelated osx failure. I will merge this now.