flippmoke commented 7 years ago

Fix for incorrectly using buffered query extent when it was simply a correctly transformed unbuffered extended that was required for vector tile creation.

In a most basic sense the changes associated with https://github.com/mapbox/mapnik-vector-tile/pull/233 were slightly incorrect as the resolution was based on the buffered area rather then the unbuffered area for the query. This was causing issues with assumptions around tile_width and pixel_width in some calculations.

/cc @lukasmartinelli @springmeyer

codecov-io commented 7 years ago

Codecov Report

Merging #245 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   60.01%   60.01%           
=======================================
  Files          30       30           
  Lines        2111     2111           
=======================================
  Hits         1267     1267           
  Misses        844      844

Impacted Files	Coverage Δ
src/vector_tile_layer.hpp	`100% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2faa9fb...eec6b4e. Read the comment docs.

springmeyer commented 7 years ago

noting this reverts this test fixture change as well: https://github.com/mapbox/mapnik-vector-tile/commit/6ec57f78c65ef0be749e4a59f0d1164b14d2e727

mapbox / mapnik-vector-tile

Buffered Query Resolution Fix #245

Codecov Report