Closed rafatower closed 6 years ago
Merging #248 into master will increase coverage by
0.69%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 64.08% 64.77% +0.69%
==========================================
Files 30 30
Lines 2230 2308 +78
==========================================
+ Hits 1429 1495 +66
- Misses 801 813 +12
Impacted Files | Coverage Δ | |
---|---|---|
src/vector_tile_processor.hpp | 0% <0%> (ø) |
:arrow_up: |
src/vector_tile_processor.ipp | 74.85% <100%> (+0.14%) |
:arrow_up: |
src/vector_tile_layer.hpp | 86.36% <100%> (-13.64%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update da7386a...3dacce9. Read the comment docs.
Thanks for this @rafatower! Nice work - looks great. Will merge now.
This fixes #218 along with a minor change in node-mapnik
What this does:
mapnik::attributes vars
to the mvt processor.processor::update_tile
to thetile_layer
, so that it can set the variables of its associated query from there (empty if not passed to the processor constructor).(thanks @Algunenano for the advice on the constructor)
This is the patch that would be required in node-mapnik to indeed pass the variables to the datasources. I haven't created a PR yet because it makes little sense until this one approved.