search

mapbox / mapnik-vector-tile

Mapnik implemention of Mapbox Vector Tile specification
BSD 3-Clause "New" or "Revised" License
553 stars 117 forks source link

Tileinfo: disable feature id as unset, when it is #251

Closed springmeyer closed 7 years ago

springmeyer commented 7 years ago

A feature MAY contain an id field. If a feature has an id field, the value of the id SHOULD be unique among the features of the parent layer.

From https://github.com/mapbox/vector-tile-spec/tree/master/2.1#42-features.

Currently tileinfo outputs 0 for unset feature id properties. Instead I think we should have the output make clear that the feature id is unset, which this PR does.

/cc @mapsam

codecov-io commented 7 years ago

Codecov Report

Merging #251 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   64.08%   64.08%           
=======================================
  Files          30       30           
  Lines        2230     2230           
=======================================
  Hits         1429     1429           
  Misses        801      801

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da7386a...cfebfae. Read the comment docs.