search

mapbox / mapnik-vector-tile

Mapnik implemention of Mapbox Vector Tile specification
BSD 3-Clause "New" or "Revised" License
552 stars 117 forks source link

Update for mapnik v3.1.x (master) #254

Closed springmeyer closed 6 years ago

springmeyer commented 6 years ago

Gets mapnik-vector-tile compiling against mapnik master (future 3.1)

springmeyer commented 6 years ago

@artemp as you work on this next week, make sure to rebase against master after #253 lands - that will help build/test this locally without needing to test via node-mapnik (important since there is critical test coverage here).

springmeyer commented 6 years ago

make sure to rebase against master after #253 lands

I went ahead and did this. So now this branch is up to date against master.

springmeyer commented 6 years ago

This branch is looking good so far. Tests are passing locally. The remaining work to do is to update the mason package ref such that travis will pass.

refs https://github.com/mapnik/node-mapnik/pull/805

springmeyer commented 6 years ago

@artemp I think you just pushed Mapnik 3.1.x changes to master? How do they relate to this branch?

artemp commented 6 years ago

@springmeyer - make-strict-an-option-master is a master now. v3.0.x is based on old master. Sorry, I'm not following your question?

springmeyer commented 6 years ago

@artemp This PR is for merging make-strict-an-option-master into master. Sounds like you did that already. So my question is: can this be closed? It seems like you merged somehow differently than merging this PR - if so did you capture everything in this PR?

springmeyer commented 6 years ago

I think everything in this PR is already in master, closing.