mapbox / mapnik-vector-tile

Mapnik implemention of Mapbox Vector Tile specification
BSD 3-Clause "New" or "Revised" License
552 stars 117 forks source link

Revert "Spherical Mercator tile bounding box is resolution-invariant" #264

Closed flippmoke closed 6 years ago

flippmoke commented 6 years ago

Reverts mapbox/mapnik-vector-tile#259

I am seeing some different results in tests after this change in node-mapnik. For now I am reverting this change and we can look at pulling back in again.

/cc @talaj

talaj commented 6 years ago

OK. My fault is I've made the pull request against v3.0.x branch, because Travis on master is failing.

flippmoke commented 6 years ago

@talaj I want this change as it makes sense, but I think we should also do it with some changes to the API as well. Dropping the tile_size parameter to the constructor all together. We should then go into node-mapnik and drop this as a requirement where possible. I feel that this might be best slated for master and the eventual v3.7.0 release of node-mapnik using mapnik (core) 3.1.x