mapbox / mapping

OpenStreetMap contributions from the data team at Mapbox
https://wiki.openstreetmap.org/wiki/Mapbox#Mapbox_Data_Team
242 stars 51 forks source link

Japan OSM improvement #120

Closed planemad closed 8 years ago

planemad commented 9 years ago

Based on observations from #116. There are multiple data issues in japan which requires a comprehensive cleanup strategy with close involvement of the Japanese OSM community.

This ticket will track all the high level conversations and strategy on improving OSM data for Japan.

Existing data issues

Data improvement strategy

  1. Select project area
    1. Priority: Urban areas > Highway corridors > Rural areas
    2. Check the accuracy of orthorectified imagery and Bing imagery by comparing with GPS data. Publish offsets if required.
    3. Evaluate extent of data offset and data freshness for the area
    4. Publish findings and communicate with local mappers to initiate a mapping task
  2. Road realignment
    1. Create a road improvement task using the tasking manager
    2. Verify imagery alignment using GPS data
    3. For gridded networks, attempt to offset data to match imagery. If not successful delete imported unnamed roads and retrace area
    4. Delete imported roads with no match to imagery
    5. Realign all other roads and mark as finished
  3. Road tracing
    1. Go through realigned tasks and invalidate to commence road tracing
    2. Trace missing roads and tracks from imagery and mark as finished
  4. Validation

Next steps

cc @mapbox/team-data

planemad commented 9 years ago

Realignment trial report 09/16

Revised data improvement strategy

  1. Focus on high priority areas based on @Rub21 tweet map image
  2. Use the primary tracing source as GSI Japan Satellite (ort) where available and fallback on Bing in other areas. Most high priority areas have GSI Satellite coverage. screenshot 2015-09-16 19 40 57
  3. Realign road network only in urban areas to GSI Japan Satellite (ort), ignore offsets (<10m) wrt Bing
  4. Trace missing roads based on tracing source

From tomorrow team-blr will try the above approach and report findings. A log of observations is maintained here

cc @mapbox/team-data

lxbarth commented 9 years ago

Wow, great progress.

In the interest of keeping the improvement process simple for the community to contribute to, the conclusion was to sacrifice small positional accuracies to maintain large scale data consistency.

@planemad - what does this concretely mean? Can you give an example for that?

planemad commented 9 years ago

@lxbarth to be as accurate as possible we were using Strava and OSM GPS to offset the Bing/GSI imagery for the best match, this is never perfect and results in an offset in another area. These continuous localized corrections which cannot be replicated exactly be someone else and adds to the data inconsistency since no source perfectly will match the data everywhere.

To make it simple, we're just going to use GSI Satellite or Bing as is without offset correction. We will skip realigning data with offsets under 10m from satellite imagery such as these and focus on adding missing roads.

screenshot 2015-09-16 20 58 10
mapconcierge commented 9 years ago

@planemad

I understand all steps. Yes, GSI ortho image layer (ort) has good accuracy.

電子国土基本図(オルソ画像)MaxZoomLv18 http://cyberjapandata.gsi.go.jp/xyz/ort/{z}/{x}/{y}.jpg source=GSImaps/ort

We have started special project team on Facebook Group with Asian addicted mappers, OSM teachers in Japan. My students will join. https://www.facebook.com/groups/697237443754399/

mapconcierge commented 9 years ago

@planemad

Mutsu city area doesn't have good GSI ort images and Strava GPS. We should choice

std 標準地図 MaxZoomLv18 http://cyberjapandata.gsi.go.jp/xyz/std/{z}/{x}/{y}.png source=GSImaps/std

2015-09-17 13 43 07

pratikyadav commented 9 years ago

Realignment trial report 09/17

screen shot 2015-09-17 at 6 30 16 pm

unsungNovelty commented 9 years ago

@mapconcierge, what kind of highway will the below road be? a service road, residential road or a living-street road?

https://www.openstreetmap.org/#map=17/40.785891873025996/140.7407283726662 japan

pratikyadav commented 9 years ago

Realignment trial report 09/21

Today @planemad @pratikyadav @ruthmaben @nikhilprabhakar and @ramyaragupathy realigned 3201 nodes in the Aomori region.

The focus under pass 1A and 2 was -

Today under pass 3, the team will realign, merge and add missing unclassified, residential roads, living streets.

screen shot 2015-09-18 at 6 15 54 pm

planemad commented 9 years ago

Realignment Summary

Realignment proposal for Japan Based on these finding this is the proposal for a large scale road network correction for Japan:

cc @mapconcierge @lxbarth @mapbox/team-data

planemad commented 9 years ago

Since we have Aomori completed till pass 2, the @mapbox/team-data is going to follow the similar procedure in the more dense Beppu-Oita region on Kyushu island from today http://tasks.openstreetmap.in/project/44

@mapconcierge would be great to have the OSM-JP community help with the validation of our work and feedback on the process.

planemad commented 9 years ago

While realigning highway junctions, make sure to fix any kinks on branching roads. untitled

Fix any incorrect highway junctions where there is no crossing screenshot 2015-09-22 17 50 48 screenshot 2015-09-22 17 51 15

.

unsungNovelty commented 9 years ago

@mapbox/team-data - Also merge and align the 4 way junctions which are split like this: untitled

samely commented 9 years ago

We already finished http://tasks.openstreetmap.in/project/31#, which is a pilot task for realignment and adding roads in Chiba.

Those are the number of editions per user

User Num OSM Objects Num Changeset Num nodes V1 Num nodes Vx Num ways V1 Num ways Vx Num relation V1 Num relation Vx
samely 77,862 333 45,220 18,416 5,856 8,370 0 0
RichRico 65,217 441 31,035 28,070 2,511 3,601 0 0
karitotp 64,290 215 32,538 21,848 4,531 5,370 0 3
Luis36995 53,561 429 24,981 21,864 2,751 3,965 0 0
calfarome 40,985 309 19,079 16,561 2,624 2,721 0 0
dannykath 38,549 653 20,531 11,481 3,563 2,973 0 1
ediyes 32,781 540 15,149 12,291 2,467 2,869 0 5
andygol 10,087 24 2,007 7,382 240 455 2 1
abel801 31,879 289 9,912 19,519 638 1,810 0 0
Rub21 1,815 31 759 711 131 214 0 0
pratikyadav 986 26 693 76 158 59 0 0
ruthmaben 767 18 236 405 58 68 0 0
jinalfoflia 311 7 240 5 52 14 0 0
nikhilprabhakar 310 5 254 9 34 13 0 0
srividya_c 294 17 167 14 75 38 0 0
ramyaragupathy 266 13 158 29 45 34 0 0
Chetan_Gowda 265 7 154 94 5 12 0 0
Total 420,225 3,357 203,113 158,775 25,739 32,586 2 10
calfarome commented 9 years ago

Team progress in Chiba Prefecture, Japan. japav22l

unsungNovelty commented 9 years ago

@mapbox/team-data : I have come across a lot of duplicate roads in the current task that we are doing (Ishikawa). For now we will be ignoring these duplicate roads and will be taking care of it in the later passes. duplicates

jinalfoflia commented 9 years ago

@mapconcierge, there is this tunnel like construction, what should it be tagged as? screen shot 2015-09-24 at 3 35 47 pm

Here is the link to the road.

planemad commented 9 years ago

Japan realignment progress map screenshot 2015-09-24 17 06 00

https://gist.github.com/planemad/64da69b20ea9705b5673

friedbunny commented 9 years ago

@jinalfoflia Coincidentally, I've been through that tunnel many times. It's an enclosed "snow shed"/"snow shelter" (スノーシェッド or スノーシェルター) situated at a mountain pass with hills rising on either side.

Here are some pictures of this structure.

It seems like the OSM tagging is covered=yes.

jothirnadh commented 9 years ago

@mapbox/team-data : Whenever there is a pre-defined tunnel or a bridge such as one in the below image, we are not making any changes due to lack of evidence if the crossing is a bridge or tunnel. screen shot 2015-09-25 at 6 06 13 pm

planemad commented 9 years ago

Progress

cc @mapbox/team-data

jinalfoflia commented 9 years ago

@friedbunny Thank you :+1:

jinalfoflia commented 9 years ago

As there are multiple roads for re-aligning, I tend to miss a few of them. To better keep track of the roads that I modified, I use this style that highlights freshness of data.

screen shot 2015-09-29 at 6 33 35 pm

/cc @mapbox/team-data

planemad commented 9 years ago

@jinalfoflia nice tip and its always a good practice to upload/download data to keep it in sync.

Rub21 commented 9 years ago

@mapbox/team-data : We've finished up the pass 2 in http://tasks.openstreetmap.in/project/45, let's start in new task http://tasks.openstreetmap.in/project/48

mapconcierge commented 9 years ago

> @Rub21 OK!! I've confirmed Fukushima Area. Our students team will join today. :-)

> @Rub21 Please add admin permission for Project 48 to me(MAPconcierge), I can translate in Japanese.

Rub21 commented 9 years ago

@mapconcierge , That is great :) , could you give me your osm users, to add in Task Manager, hmm but I think first you have to login http://tasks.openstreetmap.in/, after it I can give you permission to access.

lxbarth commented 9 years ago

mapconcierge commented 9 years ago

> @Rub MAPconcierge http://www.openstreetmap.org/user/MAPconcierge

> @lxbarth That's great!! :-)

mapconcierge commented 9 years ago

Japanese Students are doing now!! 12017556_1126710234024613_4210415448895765433_o

planemad commented 9 years ago

This is amazing @mapconcierge !

Has there been any confusion from the students, maybe you can translate the instructions in Japanese for the task?

mapconcierge commented 9 years ago

@planemad Yes, of course!! :-)

planemad commented 9 years ago

@mapconcierge sorry, thought you were already admin, done now. Also lets have subsequent tasks on http://tasks.teachosm.org with multilingual instructions, it would be great to have the community select the area that needs to be worked on based on imagery coverage map https://gist.github.com/planemad/64da69b20ea9705b5673 .

You can count on the full force of @mapbox/team-data to join in as soon as a task is up :rocket:

abel801 commented 9 years ago

We don't have GSI imagery in Japan road improvement: Fukushima I think that we have finished the task.

@planemad

Rub21 commented 9 years ago

@mapbox/team-data , I've added other task to improve Japan, #49 - Japan road improvement: Mito if you can not find more blocks to work in #48 - Japan road improvement: Fukushima can you jump to this new one

mapconcierge commented 9 years ago

> @planemad Okay thanks, I'm doing translation in Japanese. :-) http://tasks.openstreetmap.in/project/48

planemad commented 9 years ago

Mapping report of Ishikawa task screenshot 2015-10-05 14 22 38

Key observations

planemad commented 9 years ago

@mapbox/team-data based on the above observations and a voice discussion, it was decided to continue mapping in separate passes for future tasks. The most important reason for this is to detect quality issues from the previous pass.

unsungNovelty commented 9 years ago

@mapbox/team-data : Do not combine roads with different maxspeed tags speeddif

pratikyadav commented 9 years ago

japan

Seeing a lot of holes/missing strips in GSI japan satellite imagery which are not actually one when we zoom in.

@mapbox/team-data

pratikyadav commented 9 years ago

Mapping report

Pass 1 and 2 done on two tasks for the parts with Japan GSI Satellite Imagery coverage.

48 - Japan road improvement: Fukushima

screen shot 2015-10-08 at 11 25 13 am

49 - Japan road improvement: Mito

screen shot 2015-10-08 at 11 25 22 am

Currently @mapbox/team-data is working on 54 - Japan road improvement: Osaka

cc @mapconcierge

maning commented 9 years ago

For later consideration, it would interesting to log who is editing in the TM outside the data team. This is just to highlight that this work is with the rest of community in Japan.

cc @mapconcierge

planemad commented 9 years ago

Important: Relations on ways combine without warning JOSM allows combining ways with different relations without any warning. In this example, roads with the same tags but part of different bus route relations were merged with no warning dialog. This will break the bus route relation. Do not merge ways that are part of different relations. untitled

Bug report has been filed in JOSM trac: https://josm.openstreetmap.de/ticket/11945

cc @mapbox/team-data

Andygol commented 9 years ago

In order not to miss anything - use Todo Plugin

image http://wiki.openstreetmap.org/wiki/JOSM/Plugins/TODO_list

  1. Select required features
  2. Add them into Todo List
  3. Select and mark it one by one
  4. Save result
  5. Clear the list

josm-using-todo-plugin

planemad commented 9 years ago

Update

mapconcierge commented 9 years ago

> @planemad @lxbarth @maning @Rub21

I've translated @PlaneMad's post on diary of OSM.org in Japanese. http://www.openstreetmap.org/user/MAPconcierge/diary/36106

2015-10-14 14 09 15

pratikyadav commented 9 years ago

For selecting continous way use Shift + W. It grabs the continous active way upto the next intersection.

Fliter out bridges ,tunnels and minor roads.

japan11

Just keep an eye on tags while merging.

lxbarth commented 9 years ago

I've translated @PlaneMad's post on diary of OSM.org in Japanese. http://www.openstreetmap.org/user/MAPconcierge/diary/36106

So amazing. Thank you @mapconcierge !

mapconcierge commented 9 years ago

Your too :-) > @lxbarth Thanks for great challenge for Asian mappers.

planemad commented 9 years ago

@mapbox/team-data to speed up segment merging, JOSM can be configured to discard the yh:WIDTH tag automatically when editing. To do this search for the tags.discardable property in advanced JOSM settings and add yh:WIDTH to the list.

screenshot 2015-10-15 14 54 35

JOSM and iD will be updated in the next release to do this automatically for new users.

planemad commented 8 years ago

Update

screenshot 2015-10-19 18 48 37