To-fix: Broken polygons

samely commented 8 years ago

Objective

Close polygons which are broken.

Tasks

The task below is updating everyday from Monday to Friday with the latest errors in OpenStreetMap

http://osmlab.github.io/to-fix/#/task/nonclosedways
Changeset comment

Fixing invalid multipolygon relation by closing unclosed rings and self intersecting areas using #to-fix https://github.com/mapbox/mapping/issues/206

Coverage

All countries in this list: https://s3.amazonaws.com/mapbox/to-fix/mbtiles.txt

Tools

If using iD editor, work with To-Fix web
If using JOSM, work with Josm-tofix-plugin
Use split way tool (Shortcut: P)
Use unglue tool (Shortcut: G)
Instructions
If the highway has any tag for areas (i.e. landuse or buildings) delete this tag.
If the area has a self-intersect node, disengage it and reshape the area.
If editing in an actively mapped area, add a note instead of making a fix.
If satellite imagery isn't clear click on not an error of to-fix
Check in osm layer if the polygon dos not show. example
Common issues

Delete the building=yes tag

Delete the irrelevant node

How are we doing the error detection?

We are using osm-qa-tiles and osmlint selfIntersectingHighways

Who will work on these tasks?

Everybody is available to work on resolving these issues. However, @mapbox/data-team (Peru office) will work on everyday.

Question

Tag @planemad or @rub21 for questions.

cc. @mapbox/team-data

dannykath commented 8 years ago

Broken polygons issues from 07/11/2016 - 07/14/2016

Date	N° detected error	Total Fixed
Wednesday 13th, July	65652	1600
Thursday 14th, July	49930	1526
Total	--	3126

luiswalter commented 8 years ago

Broken polygons issues from 07/18/2016 - 07/22/2016

Date	N° detected error	Total Fixed
Monday 18th, July	44,430	1,992
Wednesday 20th, July	39,380	2,574
Thursday 21th, July	38,709	671
Total	--	5,237

calfarome commented 8 years ago

Broken polygons issues from 07/25/2016 - 07/27/2016

Date	N° detected error	Total Fixed
Monday 25th, July	18772	189
Wednesday 26th, July	17878	0
Thursday 27th, July	17891	0
Total	--	189

1ec5 commented 8 years ago

This changeset claims to be fixing a multipolygon, but it doesn’t look like the edited way was ever part of a multipolygon. Instead, it removed golf and natural tags added as part of iD’s Lateral Water Hazard preset. Was this intentional, and if so, should iD’s preset be corrected? According to the wiki, golf=lateral_water_hazard is legitimate, although natural=water might be inappropriate for a way.

/cc @bhousel

bhousel commented 8 years ago

Thanks for catching this @1ec5.. Indeed iD was adding broken natural=water polygons via the water hazard presets. I just fixed this! 🏌️

re https://github.com/openstreetmap/iD/issues/3483

amandasaurus commented 7 years ago

Hi! I think there might be a bug with your workflow/scripts/detection/etc. In changeset 44,381,869 mapper piligab broke a previously valid relation (relation 4,590,559 - Ballybetagh) with the changeset comment of "Fixing broken relation"

bsrinivasa commented 7 years ago

@rory Thank you for identifying this. This could have possibly happened due to flagging of the relation under ring not closed in To-Fix Task. Usually, in the cases similar to the above, the missing way segment is added into the relation but wherein in this changeset 44,381,869, the way segment 326233195 was deleted from the relation. @piligab It would be great if you can check the relation in To-Fix task and clarify why the member was removed from the relation. cc: @geohacker @Rub21 @poornibadrinath

piligab commented 7 years ago

Hi @rory! I'm not sure how this happened, maybe I could have confused any tags and deleted. I will be careful about my future editions. Thanks for your feedback.

cc. @bsrinivasa, @poornibadrinath, @Rub21, @geohacker

luiswalter commented 7 years ago