Data team peer review 8/29-9/02 - Githubissues

mapbox / mapping

OpenStreetMap contributions from the data team at Mapbox

https://wiki.openstreetmap.org/wiki/Mapbox#Mapbox_Data_Team

244 stars 51 forks source link

Data team peer review 8/29-9/02 #230

Closed krishnanammala closed 8 years ago

krishnanammala commented 8 years ago

Last peer review ticket: #227

Mapping projects to be reviewed:

To-Fix
Instructions
Download .osm files for last week.
- 2016/08/29 - 2016/09/02
Extract the tar file and select any OSM file of the team member.
Each team member will have an .osm file of edits for the last seven days. For example: latest-andygol.osm. Select any .osm file and open the data in JOSM.
If you don't find any osm file of a particular team member, then it means that user has not edited during the week.
Examine user edits in detail. In JOSM, select a random small area edited by the user and press 3 to zoom.
Download the latest data in OSM as a new layer and add a filter Cmd + F to see only the user's edits, e.g. user:andygol.

andyfilter3

Select a way/node and load the the history (Ctrl + H), the changeset comment will describe what specific project the user was working on.
To get an OSM link to the object, click Cmd + Shift + H.
Note down any feedback for each user in this ticket or comment directly in the changeset. Use this format:

username
changeset link - issue to fix

@krishnanammala @chtnha or @karitotp will post the feedback in the ticket (Use Github handle because OSM name is different from Github name) and make necessary changes on the same day.
Close the ticket once user's have fixed their edits.

For clarifications, discuss with the @mapbox/team-data in this ticket.

geochetan commented 8 years ago

@samely

Align the road to satellite imagery

https://www.openstreetmap.org/way/145661418

geochetan commented 8 years ago

@krishnanammala

Merge nodes:

http://www.openstreetmap.org/node/4180868815 and http://www.openstreetmap.org/node/2922841664

geochetan commented 8 years ago

@abhisheksaikia

Uploaded the buildings in LA from you actual account instead of import account. Do check your account before upload.

E.g: https://www.openstreetmap.org/changeset/41844924

geochetan commented 8 years ago

@nikhilprabhakar

Untagged way

https://www.openstreetmap.org/way/440275694

Self-intersecting ways:

https://www.openstreetmap.org/way/102693665

geochetan commented 8 years ago

@dannykath

Untagged buildings:

https://www.openstreetmap.org/way/440784019/history https://www.openstreetmap.org/way/440784017/history https://www.openstreetmap.org/way/440784022/history https://www.openstreetmap.org/way/440791981/history https://www.openstreetmap.org/way/440791986/history https://www.openstreetmap.org/way/440791987/history https://www.openstreetmap.org/way/440805054/history https://www.openstreetmap.org/way/440805055/history

Split this road and connect the two main segments:

https://www.openstreetmap.org/way/153970831/history

Turning circle should be connected to the node of the road:

https://www.openstreetmap.org/node/4376486055/history

geochetan commented 8 years ago

@luiswalter

highway not connected

https://www.openstreetmap.org/way/439920856

Untagged way:

https://www.openstreetmap.org/changeset/41832421

geochetan commented 8 years ago

@ediyes

Align the road to satellite imagery

https://www.openstreetmap.org/way/295035188/history https://www.openstreetmap.org/way/236476802/history

unsungNovelty commented 8 years ago

Thanks for the review guys 👍 . Below are my fixes and comments.

Untagged way

https://www.openstreetmap.org/way/440275694 - Fix

Self-intersecting ways:

https://www.openstreetmap.org/way/102693665 - No changes were made because no issues were found in the data.

krishnanammala commented 8 years ago

The issues are fixed in the broken multi-polygon problems. No need of fixing again.

Thanks for the review team 👍

ediyes commented 8 years ago

Thanks for the review @mapbox/india-office

Align the road to satellite imagery

https://www.openstreetmap.org/changeset/41978523 https://www.openstreetmap.org/changeset/41979699

dannykath commented 8 years ago

Thanks for the review team!

There are not errors for : No need of fixing again.

Untagged buildings:

https://www.openstreetmap.org/way/440784019/history https://www.openstreetmap.org/way/440784017/history https://www.openstreetmap.org/way/440784022/history https://www.openstreetmap.org/way/440791981/history https://www.openstreetmap.org/way/440791986/history https://www.openstreetmap.org/way/440791987/history https://www.openstreetmap.org/way/440805054/history https://www.openstreetmap.org/way/440805055/history

Split this road and connect the two main segments:

https://www.openstreetmap.org/way/153970831/history // not an error

Turning circle should be connected to the node of the road:

https://www.openstreetmap.org/node/4376486055/history // not an error

luiswalter commented 8 years ago

Thanks Team!

highway not connected

https://www.openstreetmap.org/way/439920856#map=17/32.15389/-106.69896

Untagged way:

https://www.openstreetmap.org/changeset/41832421#map=16/44.8795/-96.1439

samely commented 8 years ago

Thanks for reviewing team I don't consider this should be aligned since all roads are out of phase.