Data team peer review 11/23 - 11/29

krishnanammala commented 7 years ago

Last peer review ticket: #247

Mapping projects to be reviewed:

To-Fix
TR refresh in US and Canada

Instructions

Download .osm files for last week.
- 2016/11/23- 2016/11/29
Extract the tar file and select any OSM file of the team member.
Each team member will have an .osm file of edits for the last seven days. For example: latest-andygol.osm. Select any .osm file and open the data in JOSM.
If you don't find any osm file of a particular team member, then it means that user has not edited during the week.
Examine user edits in detail. In JOSM, select a random small area edited by the user and press 3 to zoom.
Download the latest data in OSM as a new layer and add a filter Cmd + F to see only the user's edits, e.g. user:andygol.

andyfilter3

Select a way/node and load the the history (Ctrl + H), the changeset comment will describe what specific project the user was working on.
To get an OSM link to the object, click Cmd + Shift + H.
Note down any feedback for each user in this ticket or comment directly in the changeset. Use this format:

username
changeset link - issue to fix

@krishnanammala @chtnha or @dannykath will post the feedback in the ticket (Use Github handle because OSM name is different from Github name) and make necessary changes on the same day.
Close the ticket once user's have fixed their edits.

For clarifications, discuss with the @mapbox/team-data in this ticket.

krishnanammala commented 7 years ago

@piligab

align to imagery and strava:

too much nodes, simplify:

krishnanammala commented 7 years ago

@ediyes

align road to imagery:

https://www.openstreetmap.org/way/197373135/

too much nodes, simplify:

krishnanammala commented 7 years ago

@jothirnadh

Building not matching the basement:

krishnanammala commented 7 years ago

@chtnha

Trace building footprint correctly:

https://www.openstreetmap.org/way/452524513/history

krishnanammala commented 7 years ago

@planemad

Align the road to Satellite imagery:

krishnanammala commented 7 years ago

@manoharuss

Building doesn't exist as per Mapbox imagery:

Trace building as per imagery:

https://www.openstreetmap.org/way/453486720/history

krishnanammala commented 7 years ago

@krishnanammala

Building inside building:

https://www.openstreetmap.org/way/455464897 this should be part of the larger building refer to shadow
https://www.openstreetmap.org/way/199259026/ - this is the bigger that has 6 smaller buildings within it.
https://www.openstreetmap.org/way/292744730/
https://www.openstreetmap.org/way/199259024

krishnanammala commented 7 years ago

@ramyaragupathy

Restriction conditional should also include the time seen in the mapillary imagery:

https://www.openstreetmap.org/relation/6730989

krishnanammala commented 7 years ago

@abhisheksaikia

Extrusions to the buildings:

Map this building according to the imagery and add extrusions:

Untagged buildings:

krishnanammala commented 7 years ago

@luiswalter

Delete few non existing roads based on TIGER. Check with imageries:

https://www.openstreetmap.org/way/17635608/history

krishnanammala commented 7 years ago

@ridixcr

Align building to footprint based on imagery:

https://www.openstreetmap.org/way/292420562/history

Delete this road:

https://www.openstreetmap.org/way/456200081/history

Align road to imagery:

luiswalter commented 7 years ago

thanks team, it is right

https://www.openstreetmap.org/way/17635608/history

krishnanammala commented 7 years ago

Thanks team for the review. Here 👇 are my fixes:

ediyes commented 7 years ago

Thanks team for the review @mapbox/india-office

Here are my fixes:

align road to imagery:

https://www.openstreetmap.org/way/197373135/

too much nodes, simplify:

They are not my mistakes :point_down:

I worked on to fix tasks, please consider the change comment for the review. I think we need a complete guide for the reviews.

@dannykath puedes coordinar con @krishnanammala y trabajar en una guía, por favor.

planemad commented 7 years ago

Fixed:

jothirnadh commented 7 years ago

Thanks for the review.

Fixed: https://www.openstreetmap.org/way/175180066/history

abhisheksaikia commented 7 years ago

Thank you team for the review 👍

Fixed:

Extrusions to the buildings:

https://www.openstreetmap.org/way/455235859/history https://www.openstreetmap.org/way/455235864/history

Map this building according to the imagery and add extrusions:

https://www.openstreetmap.org/way/455235853/history https://www.openstreetmap.org/way/456919053/history https://www.openstreetmap.org/way/453581930/history

Won't fix:

Untagged buildings:

Comment: These are not untagged buildings but multipolygon buildings and the area needs to be downloaded during peer reviews otherwise they show up as untagged ways. In short, not an error.

cc @krishnanammala ^

geochetan commented 7 years ago

Fixed many duplicated buildings added by new OSM user NANDJO in Ghana. This might be a part of HOT mapping. Here is my changeset link:

https://www.openstreetmap.org/changeset/44078603

piligab commented 7 years ago

Thank you team for the review.

align to imagery and strava:

https://www.openstreetmap.org/changeset/43929605
https://www.openstreetmap.org/way/116210864/ the imagery is desfased

too much nodes, simplify:

I worked on to fix tasks, please consider the change comment for the review.

ridixcr commented 7 years ago

Thank you team for the review :wink:

Align building to footprint based on imagery:

https://www.openstreetmap.org/way/292420562

Delete this road - retagging (pedestrian)

https://www.openstreetmap.org/way/456200081

Align road to imagery:

krishnanammala commented 7 years ago

Everyone fixed the issues. No Actions here closing.

mapbox / mapping