mapbox / mapping

OpenStreetMap contributions from the data team at Mapbox
https://wiki.openstreetmap.org/wiki/Mapbox#Mapbox_Data_Team
244 stars 51 forks source link

To-fix: Double places #290

Closed Yurasi closed 7 years ago

Yurasi commented 7 years ago

Currently, there are many duplicated places in OpenStreetMap,which is not really good, and generates confusion some cases which we found are::point_down:

screenshot from 2017-04-28 11-18-49 Node 1,Node 2

screenshot from 2017-04-28 11-12-14 Node, Way.

Objective

Cleaning up doubled places in OpenstreetMap.

Tasks

We have a to-fix task, that contains the doubled places issues

https://osmlab.github.io/to-fix/#/stats/doubleplaces

Changeset comment

Fix double places:* and with the same name

Tools

# Instructions to fix - When two place nodes exist, combine the tags into one, and set the place in the center of these nodes. - When a landuse and a place node exist, combine the tags into one, replace geometry. - When a boundary and a place node exist, create a relation `type=boundary` where the polygon will be the `outer` role and the node place will be the `admin_centre` or `label` role. - When a landuse, boundary and node exist, combine the tags from landuse to boundary, except `landuse tag`, after delete the landuse. Check or add the place node into relation with `admin_centre` or `label` role. > - `admin_centre` - The node that is considered to be the administrative centre (usually the node tagged with place=city/town/village) > - `label` - The node that is considered to be a hamlet, village or neighbourhood. **More info:** - http://wiki.openstreetmap.org/wiki/Relation:boundary - http://wiki.openstreetmap.org/wiki/Tag:boundary%3Dadministrative - http://wiki.openstreetmap.org/wiki/Tag:boundary%3Dadministrative#admin_level - http://wiki.openstreetmap.org/wiki/Key:place - http://wiki.openstreetmap.org/wiki/Talk:Relation:boundary - https://wiki.openstreetmap.org/wiki/Relation:boundary#Relation_members ### Common issues ### Case 1: ![point](https://cloud.githubusercontent.com/assets/12261974/25584984/fed3d27c-2e5d-11e7-9d74-fe49c0fc56e6.gif) _Select the two place points at the same time, after press the `E` key (Replace Geometry)._ ### Case 2: ![replace](https://cloud.githubusercontent.com/assets/12261974/26115554/ea8a9804-3a25-11e7-9cd9-94e81a91acf8.gif) _Select the place point and the landuse at the same time, after press the `E` key (Replace Geometry)._ ### Case 3 ![boundary](https://cloud.githubusercontent.com/assets/12261974/26115207/ef61ddac-3a24-11e7-8a82-6e4c0ab10c5c.gif) _Select the boundary and node at the same time, then add these in a relation of `type=boundary`. Also add the place node into the relation with the rol `admin_centre`._ ### Case 4 ![boundary_landuse](https://cloud.githubusercontent.com/assets/12261974/26123049/3c15ccc0-3a3f-11e7-81bf-b78da21a6693.gif) _Select the landuse and copy the tags that lack into the boundary, after delete that landuse. Add the place node into the relation with the rol `admin_centre`._ # How are we doing the error detection? We are using [osm-qa-tiles](https://osmlab.github.io/osm-qa-tiles/) and osmlint [doublePlaces](https://github.com/osmlab/osmlint/tree/master/validators/doublePlaces) to get a geojson file of these issues and then we uploaded into [to-fix](https://osmlab.github.io/to-fix/#/stats/doubleplaces). # Who will work on these tasks? Anybody on the community who is interesting on cleaning up these issues. ### Question Any questions, please drop a comment to discuss it. cc. @mapbox/team-data
piligab commented 7 years ago

In this case, How does it solve? There are 2 points and a landuse with the same name San Francisco Del Monte Subdivision https://www.openstreetmap.org/way/153303599 case

In OpenStreetMap, It shows like this https://www.openstreetmap.org/#map=19/14.43091/121.01238 case2

cc. @Yurasi

Rub21 commented 7 years ago

:hand: @ian29 @ajashton @ingalls , could you help us on this issue https://github.com/mapbox/mapping/issues/290#issuecomment-299311120?

Andygol commented 7 years ago
  1. Due to the fact that node (https://www.openstreetmap.org/node/3929066188) is inside of the "Veraville Homes 1" (https://www.openstreetmap.org/relation/3291321) I I would delete this node.
  2. The node https://www.openstreetmap.org/node/255059566 is good to merge with https://www.openstreetmap.org/relation/3291321 as they are the same.
  3. The node https://www.openstreetmap.org/node/255064224 is good to merge with https://www.openstreetmap.org/way/153303599 as they are the same too

cc @Yurasi @piligab

Yurasi commented 7 years ago

case_pili This is the solution recommend by @Andygol. Thanks :)
cc. @Andygol @Rub21 @piligab.