mapbox / mapping

OpenStreetMap contributions from the data team at Mapbox
https://wiki.openstreetmap.org/wiki/Mapbox#Mapbox_Data_Team
242 stars 51 forks source link

[Netherlands] Reviewing osmlint-osmium and osmlint data issues #366

Open vladaboitsik opened 4 years ago

vladaboitsik commented 4 years ago

Background

As part of on-going work to improve the quality of OpenStreetMap data, we recently used osmlint-osmium and osmlint for detecting issues related to road network data in Netherlands. In total, there were 2432 issues detected across 10 types of linters. Here ypu can find our page in OSM Wiki

Timeframe

We plan to start reviewing detected issues by the end of next week, and editing OpenStreetMap data to fix valid issues.

Tools

We will use existing OpenStreetMap editing tools, and using the #hashtag mbx_netherlands_roads

Editor: iD or JOSM Satellite Imagery: Bing, Maxar, Esri Street Level Imagery: Mapillary, Other open sources if available

Contact Person

We welcome feedback, suggestions, and insights from local mappers. If you have questions about this work, or a specific edit by our team, please reach out to Natalia at Natallia (natallia.zhouner@mapbox.com) or post a comment in a changeset.

Linter Output

Issue Netherlands Total Data
Crossing Highways 370 crossinghighways.geojson.zip
Missing Role 54 tr-missingroletr.geojson.zip
Impossible Angle 45 impossibleangle.geojson.zip
Impossible Oneways 356 impossibleoneways.geojson.zip
Island Highways 206 islandshighways.geojson.zip
Mixed Layer 21 mixedlayer.geojson.zip
Missing Type Restriction 14 tr-missingtyperestrictiontr.geojson.zip
Excessive Roles 12 tr-excessiverolestr.geojson.zip
Invalid Roles 15 tr-invalidroletr.geojson.zip
Crossing Highways Buildings 1339 crossinghighwaysbuildings.geojson.zip

Examples

Impossible angle or what we usually call “dragged node”. Link to example you can find here

изображение

Also found unconnected roads. To be routable, they should be connected into the road network. You can find example here

изображение

And here

изображение

@legain @Andygol @abrohood @shvrm

SanderH commented 4 years ago

For Crossing Highways Buildings you may want to exclude situations where the crossing highway and building already have a different layer.

jdhoek commented 4 years ago

False Positives: Impossible Oneways

Terminating on valid entrances

Way 755626484, and similar:

When a oneway way terminates on a node with entrance tagging, then it is not an impossible oneway. In this case the node is a parking garage entrance (amenity=parking_entrance). This is valid.

Another one: this one terminates on entrance=yes, which is fine if the inside path is not known or simply not drawn.

jdhoek commented 4 years ago

Crossing Highways Buildings

This geojson looks incomplete. It is possible the rest of the country doesn't have any warnings, but statistically unlikely.

incomplete-crossing

jdhoek commented 4 years ago

False positives: Island Highways

If a way has access=no|private like here, then ignore it.

This one is connected though: to an aeroway=taxiway. Good enough for the local air force.

Weird though. Your linter is not picking up this one. Also valid and an island.

Isolated bridges may mean that the ways leading up to them are unknown, or are not mappable. This is common with agricultural tracks crossing streams. For boats and other water-based transport classes these bridges are useful to know of, even though they are not connected to the grid. You are correctly ignoring this one, but trigger on this one. Is the highway class used as well?

jdhoek commented 4 years ago

Invalid Roles

All positives. I think I fixed them all.

IIVQ commented 4 years ago

I looked at a few crossing ways (but did not fix them yet)

Just to name a few. Is this helpful?

vladaboitsik commented 3 years ago

Thanks a lot to everyone who took part in reviewing linters results! In the near future we are going to review it again and continue our activity in the Netherlands. When we download new json files, they'll be posted here.

vladaboitsik commented 3 years ago
Our team is going to continue to review linters results in Netherlands soon. There were 874 issues detected across 9types of linters. Json files could be found below in the table. Issue Netherlands Total Data
Crossing Highways 302 crossinghighways.zip
Crossing Highway Bridges 5 crossinghighwaysbridges.zip
Missing Role 45 missingroletr.zip
Impossible Angle 12 impossibleangle.zip
Impossible Oneways 295 impossibleoneways.zip
Island Highways 178 islandshighways.zip
Mixed Layer 16 mixedlayer.zip
Missing Type Restriction 15 missingtyperestrictiontr.zip
Invalid Roles 6 invalidroletr.zip

Your questions and feedback are welcomed!

JohnProv commented 3 years ago

You could make use of dutch aerial photos: https://www.beeldmateriaal.nl/ Available via PDOK: https://www.pdok.nl/introductie/-/article/luchtfoto-pdok

vladaboitsik commented 3 years ago

@jdhoek Thank you!

jdhoek commented 3 years ago

The links to the linter data files above are all broken or not viewable by people outside of your organisation.

vladaboitsik commented 3 years ago

@jdhoek sorry, now it should works.

vladaboitsik commented 3 years ago

Our team finished review of all detected issues, that's why for this moment this ticket is closed. If we're going to review one more time, we'll announce it for community first.

sonyahilchik commented 3 years ago

Netherlands is reviewed on permanent bases from the start of September. Once a week there's a upload of data and team close these issues.

For 2 weeks we reviewed 203 items and fixed 122 of them.

Screenshot from 2021-10-05 12-15-41

We'll continue our work and will update this ticket with metrics about our fixes.

sonyahilchik commented 2 years ago

For October the team reviewed 231 items and fixed 58.44% from them.

Screenshot 2021-11-25 at 14 21 08

We'll continue our work and will update this ticket with metrics about our fixes.

sonyahilchik commented 2 years ago

For November the team reviewed 305 items and fixed 68.44% from them.

Screenshot 2021-12-07 at 14 23 18
danieldegroot2 commented 2 years ago

@sbelemey Editors and PDOK have 7.5cm imagery available since last year. You can also use Esri's 'enhanced' imagery (essentially the same imagery with some filters applied) which should be available in most places, though on some zoom levels may show older imagery (so be careful).

(Edit: assumed vladaboitsik was still active, seems to not be the case)

sbelemey commented 2 years ago

Hello, @danieldegroot2! thanks for information! We mostly use PDOK satellite for mapping in Netherlands.

Best regards, Sergey