mapbox / mapping

OpenStreetMap contributions from the data team at Mapbox
https://wiki.openstreetmap.org/wiki/Mapbox#Mapbox_Data_Team
242 stars 51 forks source link

[Belgium] Reviewing osmlint-osmium and osmlint data issues #370

Open vladaboitsik opened 3 years ago

vladaboitsik commented 3 years ago

Background

As part of on-going work to improve the quality of OpenStreetMap data, we recently used osmlint-osmium and osmlint for detecting issues related to road network data in Belgium. In total, there were 227 issues detected across 10 types of linters. Our plan is to review all detected issues and fix it in OpenStreetMap. There's a link to our OSM Wiki page.

Timeframe

We plan to start reviewing detected issues by the end of the week, and editing OpenStreetMap data to fix valid issues.

Tools

We will use existing OpenStreetMap editing tools, and using the #mbx_linters_belgium Editor: iD or JOSM Satellite Imagery: Bing, Maxar, Esri Street Level Imagery: Mapillary, Other open sources if available

Contact Person

We welcome feedback, suggestions, and insights from local mappers. If you have questions about this work, or a specific edit by our team, please reach out to Natallia (natallia.zhouner@mapbox.com) or post a comment in a changeset.

Linter Output

Issue Belgium Total Data
Crossing Highways 47 crossinghighways.zip
Crossing Highway Bridges 1 crossinghighwaysbridges.zip
Missing Role 49 tr-missingroletr.zip
Impossible Angle 20 impossibleangle.zip
Impossible Oneways 49 impossibleoneways.zip
Island Highways 32 islandshighways.zip
Mixed Layer 15 mixedlayer.zip
Missing Type Restriction 4 tr-missingtyperestrictiontr.zip
Excessive Roles 7 tr-excessiverolestr.zip
Invalid Roles 3 tr-invalidroletr.zip

Examples

Impossible angle or what we usually call “dragged node”. Link to example you can find here. image

One more such example image

Also found crossing roads without common point. You can find example here: image

Moreover found unconnected roads. To be routable, they should be connected into the road network. You can find example here image

Your comments and questions are welcome here

@mapbox/data-rave-navigation-feedback @Andygol @abrohood @shvrm

gplv2 commented 3 years ago

You can find the BE community online here : https://app.element.io/?#/room/#osmbe:matrix.org

vladaboitsik commented 3 years ago

@gplv2 thank you!

vladaboitsik commented 3 years ago

Our team finished review of all detected issues, that's why for this moment this ticket is closed. If we're going to review one more time, we'll announce it for community first.

joostschouppe commented 3 years ago

I'm a little confused that this issue is closed, but that there were 260 changesets tagged mbx_linters_belgium in May.

vladaboitsik commented 3 years ago

Hi @joostschouppe ! Thank you for mentioning it, seems like it was so fast project and took about 1 day for the team so we didn't update this ticket, sorry for that. There's the list of reviewed issues below

Linter Output for Belgium

Issue BelgiumTotal Data
Crossing Highways 74 crossinghighways.json.zip
Island Highways 104 islandshighways.json.zip
Impossible Angle 22 impossibleangle.json.zip
Impossible Oneways 37 impossibleoneways.json.zip
Mixed layer 28 mixedlayer.json.zip
Missing Role 107 tr-missingroletr.json.zip
Excessive Roles 6 tr-excessiverolestr.json.zip
Invalid Roles 5 tr-invalidroletr.json.zip

The results

Screenshot 2021-06-03 at 15 02 16 Screenshot 2021-06-03 at 15 02 29
joostschouppe commented 3 years ago

Thanks for that! I just mention it because there were a few comments on the changesets made. I do believe they have been addressed by your team.

vladaboitsik commented 3 years ago

@joostschouppe there were about 5 comments in general, and we discussed each of them inside the team, thanks for such cool feedback!

sonyahilchik commented 3 years ago

Belgium is reviewed on permanent bases from the start of September. Once a week there's a upload of data and team close these issues.

For 3 weeks we reviewed 331 items and fixed 206 of them.

Screenshot from 2021-10-05 12-29-00

We'll continue our work and will update this ticket with metrics about our fixes.

sonyahilchik commented 2 years ago

For October the team reviewed 343 items and fixed 62.10% from them.

Screenshot 2021-11-25 at 14 20 41

We'll continue our work and will update this ticket with metrics about our fixes.

sonyahilchik commented 2 years ago

For November the team reviewed 367 items and fixed 74.47% from them.

Screenshot 2021-12-07 at 13 43 38