mapbox / mapping

OpenStreetMap contributions from the data team at Mapbox
https://wiki.openstreetmap.org/wiki/Mapbox#Mapbox_Data_Team
240 stars 51 forks source link

[Croatia] Reviewing osmlint-osmium and osmlint data issues #412

Open sbelemey opened 2 years ago

sbelemey commented 2 years ago

Background

As part of on-going work to improve the quality of OpenStreetMap data, we use internal Mapbox data validation jobs that search OSM data for errors for detecting issues related to road network data in Croatia. In total, we are going to review issues in 7 categories.

Our plan is to review all detected issues and fix it in OpenStreetMap. There's a link to the OSM Wiki page.

Timeframe

We are going to start review in the end of April 2022.

Tools

We will use existing OpenStreetMap editing tools, we will use #hashtag for the project #mapbox_linters_croatia

Editor: iD Satellite Imagery: dgu.hr: Croatia 2019-2020 aerial imagery, osm-hr: Zagreb 2018 Aerial imagery, Bing, Maxar, Esri Street Level Imagery: Mapillary, other open sources if available

Contact Person

We welcome feedback, suggestions, and insights from local mappers. If you have questions about this work, or a specific edit by our team, please reach out to Natallia (natallia.zhouner@mapbox.com). Also you can leave a comment in a changesets.

Linter Output for Croatia

Here are json files by categories, you can watch them through geojson.io Issue Data
Crossing Highways HR_crossinghighways.zip
Island Highways HR_islandhighways.zip
Impossible Angle HR_impossibleangles.zip
Impossible Oneways HR_impossibleoneways.zip
Missing Role HR_tr-missing_role_tr.zip
Excessive Roles HR_tr-excessive_role_tr.zip
Invalid Role HR_tr-invalid_role_tr.zip

cc @abrohood @shvrm @lukasmartinelli @vladaboitsik @sonyahilchik

ihabunek commented 1 year ago

Hi! Thanks for your work.

I'm trying to review these using geojson.io, however I'm running into errors. Upon inspecting the provided geojson files I noticed that the root FeatureCollection object contains a list of other FeatureCollection objects (which in turn contain Feature objects). This is not valid according to RFC 7946.

A FeatureCollection object has a member with the name "features". The value of "features" is a JSON array. Each element of the array is a Feature object as defined above.

If you could provide valid geojson files that would be great.

dzianis-balyka commented 1 year ago

Hi @ihabunek, I flattened 2nd level FeatureCollection to match RFC and removed empty properties for top level FeatureCollection. Please take a look.

HR_crossinghighways.zip HR_islandhighways.zip HR_impossibleangles.zip HR_impossibleoneways.zip HR_tr-missing_role_tr.zip HR_tr-excessive_role_tr.zip HR_tr-invalid_role_tr.zip

Screenshot from 2022-11-15 12-17-57